Defined TimeoutTable for the user to customize timeouts#140
Merged
andreagilardoni merged 2 commits intoarduino-libraries:masterfrom Jul 2, 2025
Merged
Defined TimeoutTable for the user to customize timeouts#140andreagilardoni merged 2 commits intoarduino-libraries:masterfrom
andreagilardoni merged 2 commits intoarduino-libraries:masterfrom
Conversation
b17f6b1 to
e1983a0
Compare
|
Memory usage change @ e1983a0
Click for full report table
Click for full report CSV |
Contributor
|
@andreagilardoni what do you think about adding also another function to just change one interval? Something like
I think it would be more handy if users have to change only one interval and not the entire table. |
Contributor
Author
|
It seems to be a good idea, I will add it. |
e1983a0 to
29cb23c
Compare
changing the approach from defining a static array CHECK_INTERVAL_TABLE we can allow the user to change timeout values at runtime depending on his needs.
29cb23c to
7a9f07b
Compare
|
Memory usage change @ 7a9f07b
Click for full report table
Click for full report CSV |
Contributor
|
@andreagilardoni LGTM, I would add it to the example, what do you think? |
|
Memory usage change @ 98ca332
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing the approach from defining a static array CHECK_INTERVAL_TABLE we can allow the user to change timeout values at runtime depending on his needs.
This addresses #139